feat: implement update stastics #511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Jan 16, 2026
HeartLinked
force-pushed
the
feat/update_statistics
branch
from
6946972 to
07c45c3
Compare
wgtmac
reviewed
Jan 20, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Mostly looking good now. I have some minor comments.
src/iceberg/json_internal.cc
Outdated
| case TableUpdate::Kind::kSetStatistics: { | ||
| const auto& u = internal::checked_cast<const table::SetStatistics&>(update); | ||
| json[kAction] = kActionSetStatistics; | ||
| json[kStatistics] = ToJson(*u.statistics_file()); |
Member
There was a problem hiding this comment.
check if u.statistics_file() is null before calling ToJson
HeartLinked
force-pushed
the
feat/update_statistics
branch
from
311ed16 to
b2ef431
Compare
Member
|
Could you please resolve the merge conflict? |
HeartLinked
force-pushed
the
feat/update_statistics
branch
from
b2ef431 to
bb2bb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.